Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser webview crash when navigating back on any page #708

Closed
GeetaSarvadnya opened this issue Aug 8, 2018 · 7 comments · Fixed by brave/brave-core#376 or brave/brave-core#378
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 8, 2018

Description

Open Web store page from Show Apps option, click on go back button twice on web store page is causing browser crash

Steps to Reproduce

  1. Open Brave Core with clean profile from CLI
  2. Click on 'Skip welcome tour' on welcome page
  3. Click on More Apps icon
  4. Observe web store page display
  5. Click on web store icon
  6. Click on go back < button twice on web store page

Actual result:

Browser crashes:

Crash Id:
Crash ID 304e326a-1be1-4b2a-abe2-2a95c37a55a1
brave core - browser crash issue

Expected result:

Browser should not crash

Reproduces how often:

Always

Brave version (about:brave info)

Version 0.53.1 Chromium: 69.0.3497.12 (Official Build) dev (64-bit)

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? - No
  • Is the issue reproducible on the latest version of Chrome? -No

Additional Information

cc: @bbondy

@GeetaSarvadnya GeetaSarvadnya changed the title Web store page click from Show Apps is causing browser crash Web store icon click from Show Apps is causing browser crash Aug 8, 2018
@GeetaSarvadnya GeetaSarvadnya added this to the Backlog milestone Aug 8, 2018
@srirambv
Copy link
Contributor

srirambv commented Aug 8, 2018

Console log for the crash

$ npm run start Release

> brave@0.54.0 start C:\brave-browser
> node ./scripts/commands.js start "Release"

C:\brave-browser\src\out\Release\brave.exe --enable-logging --v=0 --disable-brave-update
[11192:15496:0808/082640.122:ERROR:gpu_process_transport_factory.cc(1007)] Lost UI shared context.
[11192:12096:0808/163945.628:ERROR:socket_stream.cc(210)] Closing stream with result -100
[11192:12096:0808/170053.364:ERROR:socket_stream.cc(210)] Closing stream with result -100
[11192:15496:0808/170415.690:ERROR:media_internals.cc(102)] Cannot get RenderProcessHost
null
null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave@0.54.0 start: `node ./scripts/commands.js start "Release"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the brave@0.54.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Owner\AppData\Roaming\npm-cache\_logs\2018-08-08T21_28_50_288Z-debug.log

@srirambv srirambv changed the title Web store icon click from Show Apps is causing browser crash Browser crash when navigating back from Webstore page Aug 8, 2018
@srirambv
Copy link
Contributor

I can consistently reproduce the crash with following str as well

  1. Open a new tab
  2. Visit duckduckgo.com
  3. Use mouse back button to navigate back
  4. Tab crashes but still navigates back to new tab

@srirambv srirambv changed the title Browser crash when navigating back from Webstore page Browser webview crash when navigating back on any page Aug 10, 2018
@bbondy bbondy modified the milestones: Backlog, Releasable builds 0.55.x Aug 16, 2018
@bbondy bbondy added the QA/Yes label Aug 17, 2018
@GeetaSarvadnya
Copy link
Author

Issue still persists hence reopening the issue.

Crash Id:
Uploaded Crash Report ID a95cccd79d4dbc34 (Local Crash ID: cfc29331-1645-452f-9e28-80a013ab9d52)
Crash report captured on Tuesday, August 21, 2018 at 12:37:39 PM, uploaded on Tuesday, August 21, 2018 at 12:38:30 PM
browser crash_click back button

@srirambv
Copy link
Contributor

This needs to be tested on the next build. Fix is not part of 0.54.x build.

@srirambv
Copy link
Contributor

Able to crash the browser when navigating back. Console logs Segmentation Fault
Crash ID 4256b899aed41f09
708

cc: @bbondy

@srirambv srirambv reopened this Aug 24, 2018
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Aug 25, 2018

Re-validate the issue against the new build 0.54.1. Issue still persists, please find the crash id below:
Crash Report ID fbbb40e8d0ba1e18
cc: @bbondy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment