Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added View on Block Explorer Button to Panel #11219

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

Added a View on block explorer button to the Wallet Panel more menu

Resolves brave/brave-browser#19655

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2021-11-22.at.11.01.54.AM.mov

@Douglashdaniel Douglashdaniel self-assigned this Nov 22, 2021
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Douglashdaniel Douglashdaniel merged commit 55ca757 into master Nov 22, 2021
@Douglashdaniel Douglashdaniel deleted the add-block-explorer-to-panel branch November 22, 2021 21:01
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 22, 2021
Douglashdaniel added a commit that referenced this pull request Nov 23, 2021
Added View on Block Explorer Button to Panel
Douglashdaniel added a commit that referenced this pull request Nov 23, 2021
Added View on Block Explorer Button to Panel
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.34.31 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64 translated)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 12.0.1 (Build 21A559)
  • Verified new option for View on Block Explorer is shown on panel
  • Verified clicking on it loads a new tab and opens the account address on block explorer
  • Verified changing network from mainnet to testnet loads the correct block explorer page

#11228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a menu item on the panel for viewing account on Etherscan
3 participants