Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a menu item on the panel for viewing account on Etherscan #19655

Closed
Tracked by #19722
bbondy opened this issue Nov 22, 2021 · 1 comment · Fixed by brave/brave-core#11219
Closed
Tracked by #19722

Add a menu item on the panel for viewing account on Etherscan #19655

bbondy opened this issue Nov 22, 2021 · 1 comment · Fixed by brave/brave-core#11219
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.32.x - Release #2

Comments

@bbondy
Copy link
Member

bbondy commented Nov 22, 2021

Add a "View Account on Etherscan" option to this menu:
Screen Shot 2021-11-22 at 11 47 53 AM

Reported via the 4th point in https://community.brave.com/t/new-brave-wallet-missing-features/304532
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 22, 2021
@Douglashdaniel Douglashdaniel self-assigned this Nov 22, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 22, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 22, 2021
This was referenced Nov 23, 2021
Merged
Merged
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 23, 2021
@srirambv srirambv mentioned this issue Nov 24, 2021
Closed
9 tasks
@srirambv
Copy link
Contributor

Brave 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010) 		☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified new option is shown on panel to open link in block explorer
  • Verified changing network loads the correct block explorer for that network

@kjozwiak kjozwiak mentioned this issue Nov 25, 2021
Closed
@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.32.x - Release #2
Development

Successfully merging a pull request may close this issue.

Added View on Block Explorer Button to Panel brave/brave-core
5 participants
@bbondy @kjozwiak @srirambv @LaurenWags @Douglashdaniel