Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 15min for NTP SI Component check interval #10817

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 2, 2021

fix brave/brave-browser#19154

To deliver new SI at a more accurate timing,
let's use 15min update check interval.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

fix brave/brave-browser#19154

To deliver new SI at a more accurate timing,
let's use 15min update check interval.
@simonhong simonhong requested a review from bsclifton November 2, 2021 01:04
@simonhong simonhong self-assigned this Nov 2, 2021
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ++

@simonhong simonhong merged commit 488a0f4 into master Nov 4, 2021
@simonhong simonhong deleted the adjust_ntp_si_component_update_interval branch November 4, 2021 06:44
@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use more shorter NPT SI component update check interval
2 participants