Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more shorter NPT SI component update check interval #19154

Closed
simonhong opened this issue Nov 2, 2021 · 2 comments · Fixed by brave/brave-core#10817
Closed

Use more shorter NPT SI component update check interval #19154

simonhong opened this issue Nov 2, 2021 · 2 comments · Fixed by brave/brave-core#10817
Assignees
@simonhong
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-macOS release-notes/exclude
Milestone
1.33.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Nov 2, 2021 •
edited
Loading

Test plan 1.

  1. Start Brave. Check component version in brave://components for sponsored image
  2. Have someone publish a new component
  3. 15 minutes from launching (step 1) it should update to the new version

Tip: To use dev-component, pass --use-dev-goupdater-url cmd switch.
For publishing new dev-component, ping to @simonhong.

Test plan 2.

  1. Start Brave and open brave://components
  2. Check NTP Sponsored Images component entry is changed like status: updater started every 15mins.

Description

To deliver it at a more accurate time, let's use 15min update check interval. 1h is current interval.
@simonhong simonhong self-assigned this Nov 2, 2021
simonhong added a commit to brave/brave-core that referenced this issue Nov 2, 2021
@simonhong
Set 15min for NTP SI Component check interval
f8d1671 
fix brave/brave-browser#19154

To deliver new SI at a more accurate timing,
let's use 15min update check interval.
@simonhong simonhong mentioned this issue Nov 2, 2021
Merged
24 tasks
@simonhong simonhong added the OS/Android Fixes related to Android browser functionality label Nov 2, 2021
@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 4, 2021
@stephendonner
Copy link

stephendonner commented Nov 6, 2021 •
edited
Loading

Verified PASSED using

Brave 1.33.67 Chromium: 96.0.4664.35 (Official Build) nightly (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave using --use-dev-goupdater-url
  3. loaded brave://components
  4. confirmed NTP Sponsored Images (US) component was at 1.0.71 @ 5:28pm PDT
  5. @simonhong pushed 1.0.72 to the US region
  6. waited 15 minutes
  7. confirmed NTP SI component was updated to 1.0.72 around 5:43pm PDT
1.0.71 1.0.72
Screen Shot 2021-11-05 at 5 28 33 PM Screen Shot 2021-11-05 at 5 43 20 PM

@simonhong simonhong added QA/No and removed QA/Yes labels Dec 4, 2021
@simonhong
Copy link
Member Author

Set QA/No as it's very difficult to test this on android with dev go-updater.
We already verified this on desktop(macOS).
I think it's safe to skip verifying this on Android because this fix is cross-platform code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-macOS release-notes/exclude
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Set 15min for NTP SI Component check interval brave/brave-core
2 participants
@stephendonner @simonhong