Allow scrolling of grant captcha overlay in rewards panel #10315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#18436
Currently, overlays implemented using
modal.tsx
usefixed
positioning to cover the window and center the overlay. This change addsoverflow: auto
to the window-covering element so that overlays that are larger than the current window size can be scrolled.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Programmatically simulating a constrained panel
I have not yet been able to find display settings that will cause the grant captcha UI to extend outside of the panel area. However, this situation can be simulated by programmatically reducing the size of the panel in the developer console:
Scenario: Solving captcha when rewards panel is constrained