Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant captcha in rewards panel is not scrollable #18436

Closed
zenparsing opened this issue Sep 29, 2021 · 1 comment · Fixed by brave/brave-core#10315
Closed

Grant captcha in rewards panel is not scrollable #18436

zenparsing opened this issue Sep 29, 2021 · 1 comment · Fixed by brave/brave-core#10315

Comments

@zenparsing
Copy link

zenparsing commented Sep 29, 2021

Description

If the grant captcha displayed in the rewards panel is larger than the maximum extension panel size (which seems to happen in some display configurations), then the grant captcha UI will extend outside of the visible area of the panel and the panel's scrollbars do not scroll the grant captcha content.

Steps to Reproduce

Unknown

Actual result:

Although the panel displays scrollbars, the grant captcha overlay is not scrollable.

Screen Shot 2021-09-30 at 11 02 51 AM

Expected result:

The grant captcha overlay should scroll.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

Verified PASSED using

Brave 1.32.74 Chromium: 95.0.4638.54 (Official Build) dev (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. opened the Rewards panel via brave://rewards/
  4. right-clicked in the rewards panel and click "inspect".
  5. in the developer tools, switched to the Console tab and executed the following JS:
      document.getElementById('root').style.height = '400px';
      document.getElementById('root').style.overflow = 'auto';
  1. enabled Rewards
  2. completed the CAPTCHA using the scrollbars
  3. confirmed I successfully received my grant of 30.000 BAT
example example example example example
Screen Shot 2021-10-19 at 2 30 28 PM Screen Shot 2021-10-19 at 2 30 44 PM Screen Shot 2021-10-19 at 2 30 49 PM Screen Shot 2021-10-19 at 2 31 08 PM Screen Shot 2021-10-19 at 2 31 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment