Multiple landed confirmations for the same ad view

[btlechowski]

Found when testing: #8634.
New landed confirmation is created every time landing page is opened

IMPORTANT: This is a regression. This issue is not reproducible in 1.7.x

Steps to Reproduce

1. Overwrite the catalog with Charles
   Catalog: one ad, no conversion.txt
2. Run Brave with command line: /usr/bin/brave-browser-dev --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --rewards=staging=true
3. Enable Rewards
4. Open brave.com and trigger an ad
5. Click on the ad
6. Wait for landed confirmation
7. Open https://www.youtube.com/ in a new tab
8. Wait for landed confirmation

Actual result:

Second landed confirmation is triggered for the same ad view

Log
multi_landed_log.txt

Expected result:

Only one landed confirmation is possible for the ad viewed

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Reproduced on

Brave	1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision	e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS	Ubuntu 18.04 LTS

Not reproducible on

Brave	1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
Revision	e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS	Ubuntu 18.04 LTS

cc @jsecretan @tmancey @brave/legacy_qa @rebron

[btlechowski]

It seems we had similar issue before #7249 (Thanks @LaurenWags for providing the link)

[LaurenWags]

Reproduced with

Brave	1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision	e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS	macOS Version 10.14.6 (Build 18G3020)

Used STR from description. Also confirmed this happens if I refresh the page from the issue noted by @btlechowski in #9412 (comment)

[tmancey]

Regression caused by #8634

[btlechowski]

Verification passed on

Brave	1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5406
Verified test plan from the description. Verified getting only 1 landed confirmation.
Verified Already sustained ad notification interaction for visited URL is shown in the logs when attempt is made to land same URL again
9412_1.txt

Verified test plan from #8634 (comment)
Verified that Already sustained ad notification interaction for visited URL message is not shown in the logs when trying to convert the set again
Verified that creative set cannot exceed frequency capping for conversions:

[16180:1:0526/033938.035373:INFO:ads_impl.cc(1130)] creativeSetId de5a82e1-17d6-47e0-a368-17f8f56dfeb3 has exceeded the frequency capping for conversions

Verification passed on

Brave | 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Fixes multiple landed confirmations for the same ad view brave-core#5406
• Verified test plan from the description. Verified getting only 1 landed confirmation.

[3684:17604:0528/163907.752:INFO:ads_impl.cc(463)] OnTabUpdated.IsFocused for tab id: 5
[3684:17604:0528/163907.759:INFO:ad_conversions.cc(68)] Checking ad conversions
[3684:17604:0528/163907.760:INFO:ads_impl.cc(649)] Visited URL matches the last shown ad notification
[3684:17604:0528/163907.760:INFO:ads_impl.cc(1477)] Sustain ad notification interaction in 0 hours, 0 minutes, 10 seconds at 4:39 PM
[3684:17604:0528/163907.760:INFO:ad_conversions.cc(98)] No ad conversions found
[3684:17604:0528/163917.762:INFO:ads_impl.cc(1490)] Sustained ad notification interaction
[2752:6772:0528/163917.762:INFO:confirmations_impl.cc(1150)] Confirm ad:
  creativeInstanceId: 36c84fcb-6388-45d8-81ed-5a5d986cd7ef
  creativeSetId: de5a82e1-17d6-47e0-a368-17f8f56dfeb3
  category: technology & computing
  targetUrl: https://www.youtube.com/
  geoTarget: US
  confirmationType: landed

• Verified Already sustained ad notification interaction for visited URL is shown in the logs when attempt is made to land same URL again

[3684:17604:0528/164041.428:INFO:ads_impl.cc(649)] Visited URL matches the last shown ad notification
[3684:17604:0528/164041.428:INFO:ads_impl.cc(665)] Already sustained ad notification interaction for visited URL

• Verified test plan from Already sustaining ad notification interaction is shown for conversion of the second ad within the same creative set  #8634 (comment)
• Verified that Already sustained ad notification interaction for visited URL message is not shown in the logs when trying to convert the set again

---

Verified passed with

Brave | 1.10.82 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified STR from description. Confirmed I only get one landed confirmation. Confirmed reloading the page does not provide another landed confirmation. Instead, I get the following in the logs:

[4475:775:0603/084631.223868:INFO:ads_impl.cc(649)] Visited URL matches the last shown ad notification
[4475:775:0603/084631.224182:INFO:ads_impl.cc(665)] Already sustained ad notification interaction for visited URL

• Verified test plan from Already sustaining ad notification interaction is shown for conversion of the second ad within the same creative set  #8634 (comment). Confirmed I do not see Already sustained ad notification interaction for visited URL in the logs, instead I see:

[4547:775:0603/092313.072478:INFO:ads_impl.cc(1130)] creativeSetId de5a82e1-17d6-47e0-a368-17f8f56dfeb3 has exceeded the frequency capping for conversions