Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing page after clicking an ad causes multiple landed confirmations #7249

Closed
tmancey opened this issue Dec 6, 2019 · 1 comment · Fixed by brave/brave-core#4164
Closed

Comments

@tmancey
Copy link
Contributor

tmancey commented Dec 6, 2019

Description

Refreshing page after clicking an ad causes multiple landed confirmations

Steps to Reproduce

  1. Click an ad
  2. Navigate the site to different URLs with the same domain name and refresh the page multiple times

Actual result:

Multiple landed confirmations are sent to ads-serve

Expected result:

Should only send a single landed confirmation to ads-serve

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Feb 12, 2020

Verified passed with

Brave 1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)
  • Reproduced the issue on 1.3.115
  • Verified STR from description

Verification passed on

Brave 1.4.89 Chromium: 80.0.3987.106 (Official Build) beta (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description

Verification passed on

Brave 1.4.93 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Linux
  • Verified STR from the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants