Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad Conversions on staging server fail due to 301 response code #9352

Closed
btlechowski opened this issue Apr 21, 2020 · 4 comments
Closed

Ad Conversions on staging server fail due to 301 response code #9352

btlechowski opened this issue Apr 21, 2020 · 4 comments

Comments

@btlechowski
Copy link

btlechowski commented Apr 21, 2020

On staging pretty much all ads with conversions are converted using https://travala.com/booking?check_in=* link. The server responds with 301 code and conversion is never triggered

IMPORTANT: This issue is reproducible on Brave 1.5.111 and conversions on staging were working on it #6536

Steps to Reproduce

  1. Connect to us
  2. See an ad
  3. Check if the ad shown can be converted with https://travala.com/booking?check_in=*
  4. Convert the ad using https://travala.com/booking?check_in=*

Actual result:

Ad is not converted due to 301 response code from the server
image
The page is redirected to https://www.travala.coom/booking?check_in=*
We don't handle redirects: #8663

Expected result:

Ads are converted on staging

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.5.111 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
Brave 1.9.30 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}

cc @brave/legacy_qa @rebron @jsecretan @tmancey

@tmancey
Copy link
Contributor

tmancey commented May 3, 2020

@btlechowski For ad conversions, the URL pattern must match the visited page and where that can be differences the patter must contain wildcards

@btlechowski
Copy link
Author

btlechowski commented May 5, 2020

@tmancey on staging catalog conversion patterns will not work, because the page started to redirect.
catalog:
"urlPattern":"https://travala.com/booking?check_in=*"
using this pattern will not work, because the page redirects to a different page https://www.travala.com/booking?check_in=*.
Therefor it is impossible to convert ads on staging.

Were you able to convert ads on staging US catalog?

@btlechowski btlechowski reopened this May 5, 2020
@btlechowski btlechowski assigned tmancey and unassigned btlechowski May 5, 2020
@btlechowski btlechowski removed this from the Dupe / Invalid / Not actionable milestone May 5, 2020
@tmancey tmancey assigned btlechowski and unassigned tmancey May 5, 2020
@btlechowski btlechowski assigned tmancey and unassigned btlechowski May 5, 2020
@btlechowski btlechowski added this to the 1.9.x - Beta milestone May 5, 2020
@btlechowski
Copy link
Author

@tmancey has updated catalog with new urlPattern and ad conversions started to work on staging
New urlPattern is https://www.travala.com/booking?check_in=*

@btlechowski
Copy link
Author

btlechowski commented May 5, 2020

Verification passed on

Brave 1.9.55 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Ubuntu 18.04 LTS

The ad was converted using https://www.travala.com/booking?check_in=* pattern

[2991:1:0505/191230.522112:INFO:ad_conversions.cc(131)] Ad conversion for c7f96341-726f-4e5d-9494-5686db89664b creative set id for postview
[2991:1:0505/191230.527352:INFO:ad_conversions.cc(300)] Saving ad conversions state
[2991:1:0505/191230.527534:INFO:ad_conversions.cc(289)] Started ad conversion timer for creative_instance_id 7e798d96-3ab9-4469-862d-f04d3d8b9506 with creative set id c7f96341-726f-4e5d-9494-5686db89664b which will trigger on 2020-05-05 17:22:26.000 UTC

Verified passed with

Brave | 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Confirmed ad was converted using https://www.travala.com/booking?check_in=* pattern
[2347:775:0512/050259.608558:INFO:ad_conversions.cc(250)] Ad conversion for creative instance id c1fce205-484e-4953-b546-650f5c963a42 with creative set id c7f96341-726f-4e5d-9494-5686db89664b triggered on 2020-05-12 09:02:59.000 UTC
[2347:775:0512/050259.609570:INFO:ad_conversions.cc(300)] Saving ad conversions state
[2346:775:0512/050259.609915:INFO:confirmations_impl.cc(1168)] Confirm action:
  creativeInstanceId: c1fce205-484e-4953-b546-650f5c963a42
  creativeSetId: c7f96341-726f-4e5d-9494-5686db89664b
  confirmationType: conversion

Note - encountered #9412 while testing.


Verification passed on


Brave | 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

The ad was converted using https://www.travala.com/booking?check_in=* pattern

[5972:5936:0511/200347.299:INFO:ad_conversions.cc(131)] Ad conversion for c7f96341-726f-4e5d-9494-5686db89664b creative set id for postview
[5972:5936:0511/200347.299:INFO:ad_conversions.cc(300)] Saving ad conversions state
[5972:5936:0511/200347.299:INFO:ad_conversions.cc(289)] Started ad conversion timer for creative_instance_id 1b86cc00-dc71-4c98-9e32-bd72dfba9651 with creative set id c7f96341-726f-4e5d-9494-5686db89664b which will trigger on 2020-05-11 14:38:36.000 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants