-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave Ads server retry logic should backoff exponentially with a ceiling #7226
Comments
Verification passed on
Catalog before changing the system time
Set the system time 2 hours ahead and confirmed that new catalog gets downloaded and the timestamp is different for both the catalogs
Verified the case by enabling rewards and making sure that the catalog file gets created in ads_service profile folder, after this close the browser and disconnect the internet/wifi and then delete the catalog file and reconnect the internet back and relaunch the browser and ensured that the catalog file gets created again in ads_service folder When wifi/internet is OFF catalog download fails
when wifi/internet is enabled
Failed to redeem tokens
Retry Failed confirmation
After successful retry failed confirmation queue becomed empty for View and Click confirmation types
Faied ads rewards and get payment balance
Verified success path when updating ads rewards
Verified passed with
On initial launch:
Once time had elapsed (using flag):
Confirmed once appropriate time (
Reenabled wifi, confirmed successful download of catalog:
After successful retries the failed confirmations queue is empty:
Verification passed on
On initial launch:
Once time had elapsed (using flag):
Confirmed once appropriate time was reached, catalog download retry was attempted (wifi was still off)
Reenabled wifi, confirmed successful download of catalog:
After successful retries the failed confirmations queue is empty:
|
Brave Ads server retry logic should backoff exponentially with a ceiling, as currently there are infinite retries without backing off which can cause performance issues and reduce battery life on mobile devices
The text was updated successfully, but these errors were encountered: