Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Ads server retry logic should backoff exponentially with a ceiling - 1.8.x #5225

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Brave Ads server retry logic should backoff exponentially with a ceiling - 1.8.x #5225

merged 1 commit into from
Apr 22, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 11, 2020 •
edited by kjozwiak
Loading

Uplift of #5197
Resolves brave/brave-browser#7226

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.8.x - Beta milestone Apr 11, 2020
@tmancey tmancey requested a review from a team April 11, 2020 13:15
@tmancey tmancey self-assigned this Apr 11, 2020
@kjozwiak
Copy link
Member

Restarting macOS due to build failing as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F7226-1.8.x/3/execution/node/442/log/.

06:03:13  FAILED: obj/chrome/browser/extensions/api/api_registration/generated_api_registration.o

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Apr 15, 2020
@kjozwiak
Copy link
Member

QA verified #5197 on Nightly as per #5197 (comment).

kjozwiak
kjozwiak approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 8819899 into 1.8.x Apr 22, 2020
@kjozwiak kjozwiak deleted the issues/7226-1.8.x branch April 22, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@gdregalo gdregalo Awaiting requested review from gdregalo

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

@kylehickinson kylehickinson Awaiting requested review from kylehickinson kylehickinson is a code owner

Assignees

@tmancey tmancey

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/ads
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak