Tokens fail to retry due to empty nonce #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2019
emerick
approved these changes
Dec 5, 2019
| @@ -53,12 +53,19 @@ void RefillTokens::Refill( | |||
|
|
|||
| public_key_ = public_key; | |||
|
|
|||
| nonce_ = ""; | |||
There was a problem hiding this comment.
Seems unnecessary in the constructor, but fine by me if you'd just like to be explicit.
There was a problem hiding this comment.
We need the nonce to reset if starting without the need to retry
There was a problem hiding this comment.
Got it, I misread this as being the class's constructor. Sorry!
| RequestSignedTokens(); | ||
| } | ||
|
|
||
| void RefillTokens::RetryGettingSignedTokens() { | ||
| BLOG(INFO) << "Retry getting signed tokens"; | ||
|
|
||
| if (nonce_.empty()) { |
There was a problem hiding this comment.
Is there any danger of endlessly retriggering this?
There was a problem hiding this comment.
There is, however right now we have no retry count so I will raise a ticket
There was a problem hiding this comment.
|
CI failed with unrelated error (network audit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#7222
Requires: #4106
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See brave/brave-browser#7222
Reviewer Checklist:
After-merge Checklist:
changes has landed on.