Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of initial url of a redirect is not triggered #8663

Closed
btlechowski opened this issue Mar 12, 2020 · 4 comments
Closed

Conversion of initial url of a redirect is not triggered #8663

btlechowski opened this issue Mar 12, 2020 · 4 comments

Comments

@btlechowski
Copy link

btlechowski commented Mar 12, 2020

Found when testing #6536

Redirects consist of initial url and landed url.
Conversion will not happen when initial url is covered by url pattern

Steps to Reproduce

  1. Follow steps from https://github.com/brave/internal/issues/718

Actual result:

Conversion is not performed

Expected result:

Conversion is performed

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @tmancey @jsecretan @rebron

@rebron
Copy link
Collaborator

rebron commented Mar 12, 2020

Will be fixed with #4026

@tmancey
Copy link
Contributor

tmancey commented Jul 31, 2020

Closing issue as will be resolved by #11012

@tmancey tmancey added QA/Yes release-notes/include priority/P3 The next thing for us to work on. It'll ride the trains. closed/wontfix closed/duplicate Issue has already been reported and removed closed/duplicate Issue has already been reported closed/wontfix labels Jul 31, 2020
@btlechowski
Copy link
Author

The issue is still reproducible

Brave 1.14.79 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

Also reproduced by @LaurenWags.

@btlechowski btlechowski reopened this Sep 8, 2020
@btlechowski btlechowski removed the closed/duplicate Issue has already been reported label Sep 8, 2020
@tmancey
Copy link
Contributor

tmancey commented Sep 8, 2020

Landed urls should support redirects, where conversion urls do not support redirects, as conversion urls rely on the page you are currently viewing.

@tmancey tmancey closed this as completed Sep 8, 2020
@tmancey tmancey added closed/wontfix release-notes/exclude and removed bug priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants