Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty wallet data #2183

Closed
NejcZdovc opened this issue Nov 19, 2018 · 1 comment · Fixed by brave/brave-core#927
Closed

Empty wallet data #2183

NejcZdovc opened this issue Nov 19, 2018 · 1 comment · Fixed by brave/brave-core#927

Comments

@NejcZdovc
Copy link
Contributor

Description

In some cases it can happen that user has empty walletInfo object. In this case we need to display different error then a server error. We should display error that wallet is corrupted and that they should try to recover it.

Steps to Reproduce

  1. enable rewards
  2. close browser
  3. modify ledger_state file and delete paymentId and address data
  4. start again

Actual result:

We get server error message. User can't close this notification and preform recover process.

Expected result:

User should see new error and option to close it, so that they can recover wallet

Reproduces how often:

100%

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc self-assigned this Nov 19, 2018
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 19, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 19, 2018
@NejcZdovc NejcZdovc added this to the 0.58.x - Dev milestone Nov 19, 2018
@btlechowski
Copy link

btlechowski commented Dec 13, 2018

The issue is not fixed.

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

Per our process I will log another issue: #2558

Verified I see the same as @btlechowski on macOS

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification PASSED on macOS 10.14 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux
  • verified that there's a Recover Now! link that opens chrome://rewards/#
  • ensured that you can recover a wallet without any issues
  • ensured that the correct address is being displayed under ledger_state and brave://rewards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants