Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds error flow for corrupted wallet #927

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Adds error flow for corrupted wallet #927

merged 1 commit into from
Nov 19, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 19, 2018

Resolves brave/brave-browser#2183

Native implementation: brave-intl/bat-native-ledger#182

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • close browser
  • modify ledger_state and delete paymentId
  • start browser
  • make sure that you get error about corrupted wallet

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler
Copy link
Contributor

jasonrsadler commented Nov 19, 2018

screen shot 2018-11-19 at 11 12 11 am

I like it. Should we get rid of the close button so the "Add Funds" and grant viewing aren't available?

@NejcZdovc
Copy link
Contributor Author

@jasonrsadler this was intentionally added, so that user can do backup and recovery, we could hide add funds button, let me do that

@jasonrsadler
Copy link
Contributor

It might be easier to put in a link to the backup/recover overlay. wdyt?

@NejcZdovc
Copy link
Contributor Author

nice one, implemented

image

@jasonrsadler
Copy link
Contributor

Looks good! I hate to ask one more thing, but can we make the error go away after recovering?
When recovered, close the 'recovered' message and you'll see it's still there. (Refreshing the page fixes it also).

@NejcZdovc
Copy link
Contributor Author

@jasonrsadler done

Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit e00601f into master Nov 19, 2018
@NejcZdovc NejcZdovc deleted the empty-data branch November 19, 2018 18:27
NejcZdovc added a commit that referenced this pull request Nov 19, 2018
Adds error flow for corrupted wallet
@NejcZdovc
Copy link
Contributor Author

master (0.59) e00601f
0.58 28551f6

@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty wallet data
3 participants