Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts not being blocked #1991

Closed
LaurenWags opened this issue Nov 5, 2018 · 7 comments · Fixed by brave/brave-core#818
Closed

scripts not being blocked #1991

LaurenWags opened this issue Nov 5, 2018 · 7 comments · Fixed by brave/brave-core#818
Assignees
Labels

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Nov 5, 2018

Description

Scripts are not being blocked

Steps to Reproduce

  1. Launch 0.56.8 (I was using a clean profile)
  2. Visit buzzfeed.com
  3. Toggle shields off. Let ads load.
  4. Toggle shields on.
  5. Open a new tab, navigate to brianbondy.com.
  6. Enable Block Scripts.

Actual result:

Page loads, no scripts are blocked.
screen shot 2018-11-05 at 10 08 20 am

Expected result:

Page should not load, scripts should be blocked.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Reproduced on Linux by @srirambv

@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2018

Reproduced on linux with 0.56.8.

@srirambv srirambv added this to the 0.56.x - Release milestone Nov 5, 2018
@srirambv srirambv added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 5, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Nov 5, 2018

Possibly related to #1829 which has been reported by the community about ~2 weeks ago.

@LaurenWags
Copy link
Member Author

Removed intermittent-issue label, reproducible steps found.

@onmyouji
Copy link

onmyouji commented Nov 5, 2018

Reproduced on Windows 10 Home with 0.55.22

@btlechowski
Copy link

Reproduced on Win 7 x64

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows 7 x64

@srirambv
Copy link
Contributor

srirambv commented Nov 6, 2018

Issue reproduced on 0.55.22 Chromium: 70.0.3538.77 (Official Build) (64-bit) as well so not a regression

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 7, 2018

Verification Passed on

Brave 0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Verified passed with

Brave 0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • Verified STR in description

Verified passed using

Brave 0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux
  • Verified steps mentioned in original issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants