Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global shield settings are not retained for Block scripts #2031

Closed
GeetaSarvadnya opened this issue Nov 7, 2018 · 3 comments
Closed

Global shield settings are not retained for Block scripts #2031

GeetaSarvadnya opened this issue Nov 7, 2018 · 3 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 7, 2018

Description

Identified this issue while testing #1991

Before applying Global shield settings (Block script), if you have already enabled or disabled the shield site specific scripts, then the Global shield settings will not retained.

Steps to Reproduce

  1. Clean profile 0.56.9
  2. Open Nytimes.com and enable "Scripts blocked" in shield panel
  3. Verify scripts are blocked
  4. Reset to "All scripts allowed" and verify all scripts are allowed
  5. Click "Global shield defaults" option in shield panel
  6. Enable "Scripts blocking" option
  7. Reload the Nytimes page and observe scripts are not blocking
  8. Open a new tab and enter cnn.com
  9. Verify that scripts are blocked and Global shield settings are retained

Actual result:

Global shield settings are not retained for Block scripts

block script issue_0 56 9

Expected result:

Global shield settings should retain for all websites even after enabling or disabling the scripts.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@kjozwiak @LaurenWags @srirambv @btlechowski

@GeetaSarvadnya GeetaSarvadnya added this to the 1.x Backlog milestone Nov 7, 2018
@yrliou
Copy link
Member

yrliou commented Nov 7, 2018

I think what happens here is that step 4 will add Nytimes into the allow list (can check it in chrome://settings/content/javascript), so we won't use the default shields rule but its own rule.
It seems like an expected behavior to me that the rule of a specific site has higher precedence than the default shields rule. cc @bbondy

@GeetaSarvadnya
Copy link
Author

@yrliou That's correct. I am seeing nytimes in Allow list under chrome://settings/content/javascript

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Nov 7, 2018

As per the above comment, it's expected behavior. Hence closing the issue.

@srirambv srirambv modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Nov 7, 2018
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 10, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants