Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body text in Rewards settings is too light / low contrast #1824

Closed
davidtemkin opened this issue Oct 24, 2018 · 5 comments · Fixed by brave/brave-core#759
Closed

Body text in Rewards settings is too light / low contrast #1824

davidtemkin opened this issue Oct 24, 2018 · 5 comments · Fixed by brave/brave-core#759

Comments

@davidtemkin
Copy link

The body text in Brave Rewards settings is hard to read because of low contrast.

An example of the low-contrast text in question is:

"Earn tokens by viewing ads in Brave. Ads presented are based on your interests, as inferred from your browsing behavior. No personal data or browsing history ever leaves your browser"

@jenn-rhim
Copy link

addressed in here: brave/brave-ui#235

@kjozwiak
Copy link
Member

kjozwiak commented Nov 5, 2018

@davidtemkin seems a bit darker than before but wanted to double check with you if this is good enough or should the text be a bit more darker? Added both examples below:

Using 0.55.22 Chromium: 70.0.3538.77 which is the currently released build:

old

Using 0.56.8 Chromium: 70.0.3538.77 which is the current RC which includes the above fix:

new

@davidtemkin
Copy link
Author

This is a lot better, but perhaps a little darker would be good? @jenn-rhim ?

@kjozwiak
Copy link
Member

kjozwiak commented Nov 5, 2018

@jenn-rhim we'll most likely need a new RC build because of #1991. If we want to get the above text a bit more darker as per @davidtemkin in the above comment, we'll need to get this fixed before the RC2 builds.

If we don't have the time to get this fixed today, we can create a follow up issue and QA can mark this as verified.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 6, 2018

Went through verification using the following build under macOS 10.14 x64 - PASSED

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Went through verification using the following build under Win 10 x64 - PASSED

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Went through verification using the following build under Ubuntu 18.04 x64 - PASSED

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment