Restore import definitions in 3.x #1111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better aligns our collapse behavior with other tools.
This prevents multiple incoming sequence flows to target events of an event-based gateway when the connection source is not an event-based gateway.
Handles two new scenarios: 1. A user wants to connect an event-based gateway to an event-based gateway target with existing incoming sequence flows. The existing sequence flows are removed before connecting the new one. 2. A user wants to replace a gateway, that is already connected to event-based gateway targets, with an event-based gateway. The existing incoming sequence flows of the targets, which do not belong to the newly replaced event-based gateway, are removed before the replacement operation finishes. This is because target elements in an event gateway configuration must not have any additional incoming sequence flows other than that from the event gateway.
* Restructure tests to make them more clear * Add tests for businessObject updates (especially groups)
This covers two scenarios: 1. When a shape is replaced with an expanded subprocess 2. When a subprocess is toggled from collapsed to expanded Only when: 1. There are incoming sequence flows (previous content) 2. There are no outgoing sequence flows (following content)
Adds TRBL snapping with containers only. Closes #1104
barmac
force-pushed
the
restore-import-definitions
branch
from
84b6170 to
0803df2
Compare
How do you deduce it is actively used? |
|
In any way, we should use it ourselves if we decide to keep it around. |
nikku
reviewed
Jun 27, 2019
nikku
reviewed
Jun 27, 2019
nikku
requested changes
Jun 28, 2019
barmac
force-pushed
the
restore-import-definitions
branch
from
0803df2 to
3c1dc1e
Compare
|
Done. |
This was removed in f8f9334, but it occurred that the method is used productively by some of the clients. This commit restores the method as part of public API. Use `Viewer#importDefinitions` to import previously parsed definitions. Now it is also possible to pass the diagram or diagram id to be rendered during graphical import.
nikku
force-pushed
the
restore-import-definitions
branch
from
3c1dc1e to
9c063f8
Compare
|
Merged via 63fabac. Please use different feature branches for backports and actual fix next time 🌷 |
|
OK, thanks for the feedback! |
barmac
referenced
this pull request
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores
Viewer#importDefinitionsas it occurred that it is a useful and actively used method. I removed it in f8f9334 as it wasn't documented, tested or marked in any other way as part of public API. However, as its main functionality which is opening a diagram without XML import is extremely useful, it seems to be reasonable to actually add this to the Viewer's public API.