Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently layout connections previews on create and change #744

Closed
3 tasks
nikku opened this issue Dec 22, 2017 · 0 comments · Fixed by #1028
Closed
3 tasks

Consistently layout connections previews on create and change #744

nikku opened this issue Dec 22, 2017 · 0 comments · Fixed by #1028
Assignees
@barmac
Labels
modeling ux
Milestone
M29

Comments

@nikku
Copy link
Member

nikku commented Dec 22, 2017 •
edited
Loading

Right now, we show minimal source -> target connection previews in some places (Connect, GlobalConnect). In other places (Reconnect, Create #743) we don't show any previews at all.

During Reconnect we don't apply given layout rules for the connection to be created, changed or moved (#718).

Users would benefit from a consistent connection preview, as they could easily understand how a connection would look like and its semantics (i.e. SequenceFlow vs. MessageFlow).

Expected Behavior

  • Show layouted connection preview on { Create, Connect, GlobalConnect, Reconnect }
  • Take into account changing connection type during re-connect, connect
  • Created / changed connection is layouted as shown during the preview

Depends on #718
@nikku nikku added this to the Backlog milestone Dec 22, 2017
@nikku nikku changed the title Consistently layout connections on { Connect, Reconnect } Consistently layout connections on create and change Dec 22, 2017
@nikku nikku added the backlog Queued in backlog label Feb 14, 2018
@nikku nikku removed this from the Backlog milestone Feb 14, 2018
@nikku nikku mentioned this issue Nov 29, 2018
Closed
3 tasks
@nikku nikku added this to the M29 milestone Mar 6, 2019
@mschoe mschoe mentioned this issue Mar 10, 2019
Closed
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Apr 2, 2019
@barmac barmac changed the title Consistently layout connections on create and change Consistently layout connections previews on create and change Apr 24, 2019
@barmac barmac self-assigned this Apr 24, 2019
@barmac barmac added in progress Currently worked on and removed ready Ready to be worked on labels Apr 25, 2019
This was referenced May 8, 2019
Merged
Merged
Merged
barmac added a commit that referenced this issue May 15, 2019
@barmac
feat(connection-preview): support general connection preview
38dbb39 
Closes #744
This was referenced May 15, 2019
Merged
Merged
@barmac barmac added needs review Review pending and removed in progress Currently worked on labels May 15, 2019
philippfromme pushed a commit that referenced this issue May 17, 2019
@barmac @philippfromme
feat(connection-preview): support general connection preview
8c94998 
Closes #744
philippfromme pushed a commit that referenced this issue May 17, 2019
@barmac @philippfromme
feat(connection-preview): support general connection preview
87bfe23 
Closes #744
@philippfromme philippfromme removed the needs review Review pending label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
modeling ux
Projects
None yet
Milestone
M29
Development

Successfully merging a pull request may close this issue.

Consistently layout connections previews bpmn-io/bpmn-js
3 participants
@nikku @philippfromme @barmac