Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve connection layouting when removing element #915

Closed
3 tasks
nikku opened this issue Nov 29, 2018 · 2 comments
Closed
3 tasks

Improve connection layouting when removing element #915

nikku opened this issue Nov 29, 2018 · 2 comments
Labels
enhancement New feature or request modeling
Milestone
M29

Comments

@nikku
Copy link
Member

nikku commented Nov 29, 2018 •
edited by barmac
Loading

The RemoveElementBehavior ensures that incoming and outgoing sequence flows are joined if the element between them is deleted:

foo

It does not currently keep the layout when the removed element is on the line:

foo

It does currently yield sequence flow joins in awkward, of the canvas places:

foo

Tasks

When joining two connections...

  • Detect element being removed on a line and keep layout after join
  • Relayout connection if waypoints cannot be joined reasonably (in close proximity)
  • Behave consistently on redo/undo

Related to #744, #718, #989

Depends on #718
nikku added a commit that referenced this issue Nov 29, 2018
@nikku
wip(modeling): RemoveElementBehavior
913b517 
Related to #915
@ghost ghost assigned nikku Nov 29, 2018
@ghost ghost added the in progress Currently worked on label Nov 29, 2018
@nikku nikku added modeling enhancement New feature or request backlog Queued in backlog and removed in progress Currently worked on labels Nov 29, 2018
@nikku nikku changed the title Improve connection handling when removing element Improve connection layouting when removing element Nov 29, 2018
@nikku nikku removed their assignment Nov 29, 2018
@nikku
Copy link
Member Author

nikku commented Nov 30, 2018

I've updated the issue with #917 being addressed.

@nikku nikku added this to the M29 milestone Mar 6, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Apr 2, 2019
@nikku
Copy link
Member Author

nikku commented Apr 18, 2019

Closed via #718

@nikku nikku closed this as completed Apr 18, 2019
@ghost ghost removed the ready Ready to be worked on label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request modeling
Projects
None yet
Milestone
M29
Development

No branches or pull requests
1 participant
@nikku