Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore import definitions #1112

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Restore import definitions #1112

merged 2 commits into from
Jun 28, 2019

Conversation

barmac
Copy link
Member

@barmac barmac commented Jun 27, 2019

Cf. #1111 for reference.

@barmac barmac requested a review from nikku June 27, 2019 15:28
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 27, 2019
@barmac barmac force-pushed the restore-import-definitions branch from 0803df2 to 3c1dc1e Compare June 28, 2019 06:34
barmac added 2 commits June 28, 2019 10:26
This was removed in f8f9334, but it occurred that
the method is used productively  by some of the clients.
This commit restores the method as part of public API.

Use `Viewer#importDefinitions` to import previously
parsed definitions. Now it is also possible to pass
the diagram or diagram id to be rendered during
graphical import.
@nikku nikku force-pushed the restore-import-definitions branch from 3c1dc1e to 9c063f8 Compare June 28, 2019 09:06
@nikku nikku merged commit 9c063f8 into master Jun 28, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the restore-import-definitions branch June 28, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants