Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15.x] Cherry picks of recent updates from develop #3502

Merged
merged 12 commits into from
Oct 4, 2023

Conversation

stmcginnis
Copy link
Contributor

@stmcginnis stmcginnis commented Oct 3, 2023

Description of changes:

This is a set of cherry picks from the develop branch to 1.15.x to prepare for a future 1.15.1 release.

This includes the commits from the following PRs:

Testing done:

See testing performed on develop for each change.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

jpculp and others added 7 commits October 3, 2023 21:06
The 'hyper_proxy' module is clone of tafia/hyper-proxy, but modified to
take advantage of newer Rust dependencies. Since Bottlerocket only uses
'rustls', other features and unused lines of code have been removed.

(cherry picked from commit cccc16c)
Newer versions of tungstenite implemented the v13 version of the Web
Sockets protocol (described in https://www.rfc-editor.org/rfc/rfc6455).
In this version, new headers are required in the upgrade request. With
this update, now the upgrade request sent by apiclient include the
missing headers.

In the same version, the 'frame' message was added. Neither apiserver
nor apiclient send this type of message, so they are ignored by
apiclient.

Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
(cherry picked from commit c475e12)
The filesystem will mount without specifying a specific type when
defining a systemd Mount. This allows any filesystem that the OS can
mount to be used as a filesystem for /local. Before this change, the
boot would fail if the /local filesystem didn't match the one specified
in /usr/share/bottlerocket/image-features.env

Signed-off-by: Matthew Yeazel <yeazelm@amazon.com>
(cherry picked from commit 3ac01cb)
Bumps [webpki](https://github.com/briansmith/webpki) from 0.22.1 to 0.22.2.
- [Commits](https://github.com/briansmith/webpki/commits)

---
updated-dependencies:
- dependency-name: webpki
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit d192991)
This updates the `open-vm-tools` package to use the 12.3.0 release.

There are a lot of merged changes since the previous release [0], but
most are called out as not being applicable for this package. The only
significant change appears to be the commit to add addition x509 checks
to the SAM token verification.

[0] vmware/open-vm-tools@stable-12.2.5...stable-12.3.0
[1] vmware/open-vm-tools@74b6d0d

Signed-off-by: Sean McGinnis <stmcg@amazon.com>
(cherry picked from commit f944f80)
Signed-off-by: Matthew Yeazel <yeazelm@amazon.com>
(cherry picked from commit 22bf97e)
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're going to need a twoliter update that isn't merged yet for testsys fixes.

@stmcginnis
Copy link
Contributor Author

You're going to need a twoliter update that isn't merged yet for testsys fixes.

That was going to be done in a follow up along with getting the CHANGELOG and Release.toml updates. But we can wait and just do it all in one go too.

Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to approve since team is aware of the need for a Twoliter (testsys) update.

webern added 4 commits October 4, 2023 19:13
Unfortunately the cargo install command does not seem to respect the
rust-toolchain.toml and .cargo/config.toml settings when installing from
a git reference.

rust-lang/cargo#11036

We need to fix this by adding +nightly and specifying -Z bindeps in the
cargo install command for twoliter.

(cherry picked from commit 8323260)
When we are testing changes to Twoliter, we need to install from git. In
that case the sha is not going to match the version output from Twoliter
--version. This means that we have to rebuild and install Twoliter each
time we call cargo make. It takes 10 minutes to compile Twoliter.

Fix this such that TWOLITER_ALLOW_BINARY_INSTALL=false skips checking
the version when any `twoliter` is installed.

(cherry picked from commit 31bf509)
Allow the skipping of the Twoliter version when deciding whether or not
to install Twoliter. This allows us to accept any installed Twoliter
binary and move on without re-installing.

(cherry picked from commit 21a56ae)
If the twoliter directory does not exist, make sure we create it
regardless of which installation method is being used.

(cherry picked from commit e68d6fc)
Has
- testsys fixes
- requires specification of the SDK in Twoliter.toml
- Adds logging functionality for pubsys and testsys

(cherry picked from commit 62d4af9)
@stmcginnis stmcginnis merged commit 14fa39e into bottlerocket-os:1.15.x Oct 4, 2023
@stmcginnis stmcginnis deleted the 1.15.1-updates branch October 4, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants