build: twoliter skip version check #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the skipping of the Twoliter version when deciding whether or not to install Twoliter. This allows us to accept any installed Twoliter binary and move on without re-installing.
bcressey
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Improves #3479
Description of changes:
Improves the method by which we can avoid re-installing from source when we are testing changes to Twoliter.
Testing done:
I ran this command twice and both times it took 365 seconds to install Twoliter:
cargo make -e TWOLITER_VERSION=09734ab -e TWOLITER_ALLOW_BINARY_INSTALL=false unit-testsI then ran this and the re-installation did not take place:
cargo make -e TWOLITER_VERSION=09734ab -e TWOLITER_ALLOW_BINARY_INSTALL=false -e TWOLITER_SKIP_VERSION_CHECK=true unit-testsTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.