Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix UnaryFactor jacobian #715

Closed
wants to merge 7 commits into from
Closed

fix UnaryFactor jacobian #715

wants to merge 7 commits into from

Conversation

nmahabadi
Copy link

  • Fix Unaryfactor jacobian in LocalizationExample.cpp.
  • Update gtsam document.

@nmahabadi nmahabadi mentioned this pull request Mar 15, 2021
Closed
@varunagrawal
Copy link
Collaborator

@nmahabadi can you please pull the latest develop and merge it into this PR?

@nmahabadi
Copy link
Author

Hi @varunagrawal, I fetched the latest from develop and rebased this branch to it.
Let me know if that's okey.

@varunagrawal
Copy link
Collaborator

Would have preferred a merge to avoid potential conflicts, but this works. 🙂

@varunagrawal varunagrawal linked an issue Mar 22, 2021 that may be closed by this pull request
Custom factor (unaryFactor) issue with initial heading #704
Closed
@varunagrawal varunagrawal requested a review from dellaert March 22, 2021 14:45
varunagrawal
varunagrawal approved these changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dellaert please take a look when you can.

doc/gtsam.lyx
@@ -1770,7 +1772,7 @@ filename "Code/LocalizationOutput5.txt"
Comparing this with the covariance matrices in Section
\begin_inset CommandInset ref
LatexCommand ref
reference "sub:Full-Posterior-Inference"
reference "subsec:Full-Posterior-Inference"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

dellaert
dellaert requested changes Mar 22, 2021
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many unrelated changes in build files DO NOT MERGE

@dellaert
Copy link
Member

I think something went wrong with rebase :-)
Typically, we ask people to merge develop into published branches rather than rebase to avoid surprises like this. Could you open a new PR starting from develop, cherry pick your relevant changes?

@nmahabadi
Copy link
Author

Ok I will close this PR and open a new one.

@nmahabadi nmahabadi closed this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert requested changes

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom factor (unaryFactor) issue with initial heading
4 participants
@nmahabadi @varunagrawal @dellaert @jlblancoc