-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HybridGaussianFactorGraph error #1358
Conversation
I will continue working in this branch. Please do not force-push ever. |
You got it! |
Okidoke, I fixed the ratios, and the marginals work out as well. My main changes:
Now we are in a position where the factor graph is proportional to the joint, and we can think about elimination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked over everything - but of course I made a lot of the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome sauce!
I would probably have had one PR for all the virtual methods and overloads and another PR for the logNormalizationConstant to help keep track. Reviewing this was a bit of work. |
Will merge and fix comments in next PR. |
With Frank:
Frank fixed the ratios, and the marginals work out as well:
error
method.Now we are in a position where the factor graph is proportional to the joint, and we can think about elimination.