-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed custom factors in doc/gtsam.lyx/pdf #1139
Conversation
Tangentially related question: is there a standard mathematical notation or function for extracting a pose from a transformation matrix? Something like the skew operator in the Lie algebra but for the group? Like |
Not that I know of. The group elements have different representations. We actually use (R, t) internally. You can also use a 4x4 matrix. Typically I switch between them without being explicit about it. PS1 Another equally valid representation is an 8x8 matrix, which repeats the 4x4 matrix on the diagonal. There is a whole "representation theory" about it that I once was more knowledgeable about, but I forgot most of it :-) PS2 The generalization of skew is \hat{}. And some people use the "vee" operator to do the reverse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the comments above
Sorry to rebut both those comments :-/ |
@dellaert Could we also define it as: where I have to double check my math, but I believe this gives a Jacobian similar to the original formulation (I got a negative identity matrix followed by a non-zero last column). Don't think this is advantageous, but was just curious. I was also wondering if this error could be defined in the tangent space, but I guess that doesn't make sense since |
Fixed math to agree with code and added explanation: