Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed custom factors in doc/gtsam.lyx/pdf #1139

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Fixed custom factors in doc/gtsam.lyx/pdf #1139

merged 3 commits into from
Mar 25, 2022

Conversation

dellaert
Copy link
Member

Fixed math to agree with code and added explanation:

image

doc/gtsam.lyx Outdated Show resolved Hide resolved
doc/gtsam.lyx Outdated Show resolved Hide resolved
@dellaert dellaert requested a review from xsj01 March 24, 2022 17:23
@roger-
Copy link

roger- commented Mar 24, 2022

Tangentially related question: is there a standard mathematical notation or function for extracting a pose from a transformation matrix? Something like the skew operator in the Lie algebra but for the group?

Like (x, y, theta)^T = somefunc(q) for matrix q?

@dellaert
Copy link
Member Author

Tangentially related question: is there a standard mathematical notation or function for extracting a pose from a transformation matrix? Something like the skew operator in the Lie algebra but for the group?

Like (x, y, theta)^T = somefunc(q) for matrix q?

Not that I know of. The group elements have different representations. We actually use (R, t) internally. You can also use a 4x4 matrix. Typically I switch between them without being explicit about it.

PS1 Another equally valid representation is an 8x8 matrix, which repeats the 4x4 matrix on the diagonal. There is a whole "representation theory" about it that I once was more knowledgeable about, but I forgot most of it :-)

PS2 The generalization of skew is \hat{}. And some people use the "vee" operator to do the reverse.

doc/gtsam.lyx Show resolved Hide resolved
doc/gtsam.lyx Show resolved Hide resolved
Copy link
Contributor

@xsj01 xsj01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the comments above

@dellaert
Copy link
Member Author

LGTM, except for the comments above

Sorry to rebut both those comments :-/

@dellaert dellaert merged commit 134a6b8 into develop Mar 25, 2022
@dellaert dellaert deleted the fix/doc branch March 25, 2022 01:53
@roger-
Copy link

roger- commented Mar 29, 2022

@dellaert
Above you define the error as:

image

Could we also define it as:

image

where
image
just converts from homogenous to Cartesian coordinates.

I have to double check my math, but I believe this gives a Jacobian similar to the original formulation (I got a negative identity matrix followed by a non-zero last column).

Don't think this is advantageous, but was just curious.

I was also wondering if this error could be defined in the tangent space, but I guess that doesn't make sense since m has no angle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants