Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Jacobian specified in Python Code for Custom Factor #1134

Closed
catproof opened this issue Mar 16, 2022 · 3 comments
Closed

Incorrect Jacobian specified in Python Code for Custom Factor #1134

catproof opened this issue Mar 16, 2022 · 3 comments
Assignees
@ProfFan
Labels
wrapper Related to the wrapper

Comments

@catproof
Copy link

It looks like the C++ code and python code have different Jacobians defined for GPS measurements.
@dellaert
Copy link
Member

I fixed the docs at least in PR #1139 and copied to
https://gtsam.org/tutorials/intro.html#magicparlabel-65484

@ProfFan could you fix the python code please?

@varunagrawal varunagrawal added the wrapper Related to the wrapper label Apr 2, 2022
@ProfFan ProfFan self-assigned this Apr 3, 2022
@ProfFan
Copy link
Collaborator

ProfFan commented Apr 3, 2022

Wait no. The "GPS" in the Python is for a 1-D car!

@ProfFan ProfFan closed this as completed Apr 3, 2022
@ProfFan
Copy link
Collaborator

ProfFan commented Apr 3, 2022

@NickPerezCarletonUniversity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ProfFan ProfFan

Labels
wrapper Related to the wrapper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@varunagrawal @ProfFan @dellaert @catproof