Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ethernet and PLIC #19

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

Yuan-Mao
Copy link
Collaborator

This PR adds Ethernet and PLIC.

.gitmodules Outdated Show resolved Hide resolved
@dpetrisko
Copy link
Collaborator

Hi, we want to be careful about integrating external code. Rearrange like so:

ethernet_controller/v/ ; New files
ethernet_controller/test/ ; I guess makefile to run test, if the actual TB is integrated in ethernet_controller code. If it's a new tb it can go here
ethernet_controller/import/ ; vendor files
ethernet_controller/patch.txt ; git patch for modification to vendor files
ethernet_controller/README ; commit id and description of changes to vendor code
ethernet_controller/LICENSE ; LICENSE of vendor files, from git repo

@Yuan-Mao
Copy link
Collaborator Author

Sounds good, but how would the patch.txt be useful? Isn't it enough to just include the LICENSE?

@dpetrisko
Copy link
Collaborator

patch is useful to show quickly what the diff is. Otherwise it's up to the user to clone the upstream repo and do a manual diff

@dpetrisko
Copy link
Collaborator

@Yuan-Mao
Copy link
Collaborator Author

Might need to pull out the reset for iodelay ctrl as well.
Also need to consider the sim for ssio_ddr_in

@taylor-bsg
Copy link

@Yuan-Mao @dpetrisko what remains to finalize this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants