Add osx-arm64 to biconductor biobase package. #52084
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces modifications to two files: Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)recipes/bioconductor-biobase/meta.yaml (1)
The addition of Let's verify the ARM build dependencies: Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
recipes/control-freec/build.sh(1 hunks)recipes/control-freec/meta.yaml(3 hunks)
✅ Files skipped from review due to trivial changes (1)
- recipes/control-freec/build.sh
🔇 Additional comments (3)
recipes/control-freec/meta.yaml (3)
17-17: LGTM: Build number increment is appropriate
The build number increment is correct as we're adding platform support without changing the package version.
36-38: LGTM: Improved test commands
The switch from which to test -x is a better practice as it explicitly verifies both existence and executable permissions of the scripts.
Also applies to: 40-41
45-46: LGTM: License specification follows best practices
The update to SPDX identifier GPL-2.0-or-later and addition of license_family follows conda-forge best practices.
| - linux-aarch64 |
There was a problem hiding this comment.
💡 Codebase verification
Missing osx-arm64 Platform Support
osx-arm64is not listed inadditional-platforms, which may cause build issues on ARM-based macOS systems.
🔗 Analysis chain
Verify ARM platform compatibility
Before adding platform support, we should verify:
- All dependencies support the target platforms
- No platform-specific code that might break the build
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if dependencies have ARM support
for pkg in perl r-base bioconductor-rtracklayer samtools; do
echo "Checking $pkg..."
conda search --json $pkg | jq '.[] | select(.platform == "osx-arm64" or .platform == "linux-aarch64")'
done
Length of output: 1197
Script:
#!/bin/bash
# Search meta.yaml for ARM platform specifications
rg 'osx-arm64|linux-aarch64' recipes/control-freec/meta.yaml
Length of output: 82
|
Used wrong branch - closing... |
Just adds the attribute for osx-arm64 to extra/additional-platforms section in meta.yaml.
Builds locally - let's see what CI thinks!
@jjjermiah