Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutyper: add aarch64/arm64 builds #51905

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Nov 4, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g added aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support labels Nov 4, 2024
Copy link
Contributor

coderabbitai bot commented Nov 4, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request involve updates to the meta.yaml file for the mutyper package. The version number has been incremented from 1.0.2 to 1.0.3, reflecting an update in the build section where the number field is changed from 0 to 1. The existing skip condition remains unchanged, continuing to restrict builds for Python versions less than 3.8 and greater than 3.11. A new extra section has been added, specifying additional-platforms that include linux-aarch64 and osx-arm64. This addition allows the package to be built for these platforms, enhancing its compatibility across different architectures. No modifications were made to the dependencies, requirements, or the structure of other sections within the meta.yaml file.

Possibly related PRs

Suggested labels

please review & merge

Suggested reviewers

  • rpetit3

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
recipes/mutyper/meta.yaml (1)

Line range hint 1-56: Consider adding recipe-maintainers section.

The package configuration looks good with proper version pinning and constraints. However, consider adding a recipe-maintainers section under extra to clearly identify package maintainers.

Add the following section:

extra:
  recipe-maintainers:
    - martin-g  # Add additional maintainers as needed

Also, consider documenting the supported architectures in the package documentation.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9f4b71f and 810c068.

📒 Files selected for processing (1)
  • recipes/mutyper/meta.yaml (2 hunks)
🔇 Additional comments (2)
recipes/mutyper/meta.yaml (2)

15-15: LGTM: Build number increment is appropriate.

Incrementing the build number without changing the version is the correct approach when adding new architectures without modifying the package code.


57-60: Verify architecture compatibility of dependencies.

The platform additions look correct. However, we should verify that all dependencies (especially cyvcf2 and other compiled dependencies) support these architectures.

@martin-g
Copy link
Contributor Author

martin-g commented Nov 4, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 mutyper-1.0.2-py310h7c593f9_1.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
linux-64 mutyper-1.0.2-py311hdad781d_1.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
linux-64 mutyper-1.0.2-py38h0020b31_1.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
linux-64 mutyper-1.0.2-py39hff71179_1.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-64 mutyper-1.0.2-py310h341b679_1.tar.bz2 osx-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-64 mutyper-1.0.2-py311hb338bc1_1.tar.bz2 osx-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-64 mutyper-1.0.2-py38h51c4a30_1.tar.bz2 osx-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-64 mutyper-1.0.2-py39h1841df5_1.tar.bz2 osx-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-arm64 mutyper-1.0.2-py310h6c82c4b_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/8e12a80b-8865-41cc-8691-93b378d9ee0d/artifacts/0/tmp/artifacts/packages <package name>
osx-arm64 mutyper-1.0.2-py311he5efcd3_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/8e12a80b-8865-41cc-8691-93b378d9ee0d/artifacts/0/tmp/artifacts/packages <package name>
osx-arm64 mutyper-1.0.2-py38h24147e2_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/8e12a80b-8865-41cc-8691-93b378d9ee0d/artifacts/0/tmp/artifacts/packages <package name>
osx-arm64 mutyper-1.0.2-py39hc375725_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/8e12a80b-8865-41cc-8691-93b378d9ee0d/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 mutyper-1.0.2-py310h8c4ab44_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/84cf119c-0bbe-47b6-b1bb-b2ae93fae52f/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 mutyper-1.0.2-py311h9d58220_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/84cf119c-0bbe-47b6-b1bb-b2ae93fae52f/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 mutyper-1.0.2-py38h7763450_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/84cf119c-0bbe-47b6-b1bb-b2ae93fae52f/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 mutyper-1.0.2-py39hf354171_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/84cf119c-0bbe-47b6-b1bb-b2ae93fae52f/artifacts/0/tmp/artifacts/packages <package name>

@martin-g
Copy link
Contributor Author

martin-g commented Nov 4, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Nov 4, 2024
@martin-g
Copy link
Contributor Author

martin-g commented Nov 4, 2024

mgrigorov in 🌐 euler-arm-22 in /tmp/mutyper via 🅒 test123 took 2s 
❯ tar xvf mutyper-1.0.2-py310h8c4ab44_1.tar.bz2                                                                                                                                                            (test123) 
info/run_exports.json
info/test/run_test.py
info/test/run_test.sh
info/hash_input.json
info/has_prefix
info/index.json
info/files
info/licenses/LICENSE
info/recipe/meta.yaml.template
info/recipe/meta.yaml
info/paths.json
info/recipe/conda_build_config.yaml
info/about.json
info/git
bin/mutyper
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/INSTALLER
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/WHEEL
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/LICENSE
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/RECORD
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/METADATA
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/REQUESTED
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/top_level.txt
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/entry_points.txt
lib/python3.10/site-packages/mutyper-1.0.2.dist-info/direct_url.json
lib/python3.10/site-packages/mutyper/__init__.py
lib/python3.10/site-packages/mutyper/_version.py
lib/python3.10/site-packages/mutyper/ancestor.py
lib/python3.10/site-packages/mutyper/cli.py
lib/python3.10/site-packages/mutyper/__pycache__/__init__.cpython-310.pyc
lib/python3.10/site-packages/mutyper/__pycache__/_version.cpython-310.pyc
lib/python3.10/site-packages/mutyper/__pycache__/ancestor.cpython-310.pyc
lib/python3.10/site-packages/mutyper/__pycache__/cli.cpython-310.pyc

There are no binaries in the package ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants