December updates #33
Merged
December updates #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ercel#1172) * Adds better error messages and environment variable fault tolerance * No hidden undefined
* Adds environment variable validation * Adds bracket checking in SHOPIFY_STORE_DOMAIN * Prettier * Adds link --------- Co-authored-by: Lee Robinson <lrobinson2011@gmail.com>
bc-alexsaiannyi
force-pushed
the
december-updates
branch
from
74e1d91
to
01f2755
Compare
bc-alexsaiannyi
force-pushed
the
december-updates
branch
from
cd86991
to
4612842
Compare
bc-alexsaiannyi
force-pushed
the
december-updates
branch
from
4612842
to
1bd4045
Compare
bc-alexsaiannyi
added
wip
lib/bigcommerce/storefront-config.ts
Outdated
Comment on lines
53
to
72
| export const fetchStorefrontToken = async () => { | ||
| const response = await fetch( | ||
| `${BIGCOMMERCE_API_URL}/stores/${process.env.BIGCOMMERCE_STORE_HASH}/v3/storefront/api-token-customer-impersonation`, | ||
| { | ||
| method: 'POST', | ||
| headers: { | ||
| accept: 'application/json', | ||
| 'content-type': 'application/json', | ||
| 'x-auth-token': process.env.BIGCOMMERCE_ACCESS_TOKEN!, | ||
| 'x-bc-customer-id': '' | ||
| }, | ||
| body: JSON.stringify({ | ||
| channel_id: parseInt(process.env.BIGCOMMERCE_CHANNEL_ID!), | ||
| expires_at: Math.floor(new Date().getTime() / 1000) + 1 * 24 * 60 * 60 // 1 day | ||
| }) | ||
| } | ||
| ); | ||
|
|
||
| return (await response.json()) as StorefrontTokenResponse; | ||
| }; |
There was a problem hiding this comment.
@bc-alexsaiannyi I don't see where this function is used. Do you know why it was introduced here?
There was a problem hiding this comment.
it looks like it's been a incorrect result of resolving conflicts. Thanks for catching this!
bc-alexsaiannyi
force-pushed
the
december-updates
branch
from
1bd4045
to
4ad3771
Compare
yurytut1993
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings fresh updates from Vercel, including Next.js 14.