replace cancel-workflow-action with Github's concurrency property to cancel in progress workflows #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bensijons is attempting to deploy a commit to the Vercel Solutions Team on Vercel. A member of the Team first needs to authorize it. |
bensijons
changed the title
bensijons
changed the title
bc-alexsaiannyi
pushed a commit
to bigcommerce/nextjs-commerce
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to start by saying that the reason for this PR is that I had some issues with the cancel-workflow-action when working on a project that was kickstarted by using this amazing project as a starter. Happy to get into details on that if needed but regardless I do feel there is a strong case for removing the action:
Using the cancel-workflow-action to cancel in progress workflows can be replaced with Github's native concurrency property.
The cancel-workflow-action even has a warning in its readme that the action is probably no longer needed.
This PR changes it so that test.yml workflow uses the concurrency property instead of the cancel-workflow-action. The concurrency group is the same as Sentry is using in their Github workflows.