Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes variants to use router replace #1157

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

manovotny
Copy link
Collaborator

Good point made by the community that going backwards in the browser creates an odd experience. It's better to use router.replace in this instance.

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
commerce-shopify ✅ Ready (Inspect) Visit Preview Aug 8, 2023 2:49pm

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could maybe see product images having this too, but no biggie

@leerob leerob merged commit c6eb7a3 into main Aug 8, 2023
2 checks passed
@leerob leerob deleted the router-replace-variants branch August 8, 2023 15:00
bc-alexsaiannyi pushed a commit to bigcommerce/nextjs-commerce that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants