Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add and fix shields in Readmes #9993

Merged
merged 7 commits into from
Oct 15, 2023
Merged

add and fix shields in Readmes #9993

merged 7 commits into from
Oct 15, 2023

Conversation

ameknite
Copy link
Contributor

@ameknite ameknite commented Oct 2, 2023

Objective

Fix shields

Solution

  • Correct shield in the Bevy ECS Readme, where only the MIT license is displayed
    Screenshot 2023-10-01 at 18 28 27
  • Add shields to other Readmes.
  • homogenize shields and titles.

@mockersf
Copy link
Member

mockersf commented Oct 2, 2023 •
edited
Loading

I don't think other readmes than the ones that can be used independently should have shields

@ameknite
Copy link
Contributor Author

ameknite commented Oct 2, 2023

I always thought the purpose of dividing bevy into crates was so that you could use the crates separately. Is that not the case?

@alice-i-cecile
Copy link
Member

I don't think other readmes than the ones that can be used independently should have shields

Agreed. I want this for bevy_ecs, bevy_reflect, bevy_tasks, bevy_utils and bevy_mikktspace. Those are the only ones that can be used truly independently, all the others need bevy_ecs in order to function.

@alice-i-cecile alice-i-cecile added the A-Meta About the project itself label Oct 2, 2023
alice-i-cecile
alice-i-cecile approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, you could use bevy_ptr independently too. Your call on whether to add it there.

james7132
james7132 requested changes Oct 2, 2023
View reviewed changes
@ameknite ameknite requested a review from james7132 October 2, 2023 04:16
@ameknite ameknite mentioned this pull request Oct 2, 2023
Closed
@ameknite ameknite force-pushed the fix-shields branch 2 times, most recently from 1313f9d to 57fe059 Compare October 3, 2023 18:54
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 15, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 15, 2023
Merged via the queue into bevyengine:main with commit b9ddb37 Oct 15, 2023
ameknite added a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@ameknite
add and fix shields in Readmes (bevyengine#9993)
e7e213b 
# Objective

Fix shields

## Solution

- Correct shield in the Bevy ECS Readme, where only the MIT license is
displayed
![Screenshot 2023-10-01 at 18 28
27](https://github.com/bevyengine/bevy/assets/104745335/a736a65e-0d47-4d9e-b32d-0b843a00922c)
- Add shields to other Readmes.
- homogenize shields and titles.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@ameknite
add and fix shields in Readmes (bevyengine#9993)
f9fe125 
# Objective

Fix shields

## Solution

- Correct shield in the Bevy ECS Readme, where only the MIT license is
displayed
![Screenshot 2023-10-01 at 18 28
27](https://github.com/bevyengine/bevy/assets/104745335/a736a65e-0d47-4d9e-b32d-0b843a00922c)
- Add shields to other Readmes.
- homogenize shields and titles.
@rparrett rparrett mentioned this pull request Aug 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Meta About the project itself S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameknite @mockersf @alice-i-cecile @james7132