register TextLayoutInfo and TextFlags type.
#9919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derive `Reflect` to `GlyphAtlasInfo`,`PositionedGlyph` and `TextLayoutInfo`.
ycysdf
changed the title
TextLayoutInfo and TextFlags.TextLayoutInfo and TextFlags type.
nicopap
reviewed
Sep 25, 2023
| @@ -13,6 +13,7 @@ pub mod widget; | |||
|
|
|||
| use bevy_derive::{Deref, DerefMut}; | |||
| use bevy_reflect::Reflect; | |||
| use bevy_text::TextLayoutInfo; | |||
There was a problem hiding this comment.
Suggested change
| use bevy_text::TextLayoutInfo; | |
| #[cfg(feature = "bevy_text")] | |
| use bevy_text::TextLayoutInfo; |
nicopap
reviewed
Sep 25, 2023
crates/bevy_ui/src/lib.rs
Outdated
Comment on lines
94
to
95
| .register_type::<TextLayoutInfo>() | ||
| .register_type::<TextFlags>() |
There was a problem hiding this comment.
You need to add those conditionally.
To check your changes, use the cargo check -p bevy_ui --no-default-features command
|
I also need this, I'd like if this got merged. Could you please address the comments? |
Ok. |
nicopap
approved these changes
Sep 25, 2023
ickshonpe
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Looks good, works correctly with the text feature disabled.
This wasn't done before because when I implemented TextFlags I was still afraid of touching anything to do with reflection 😅
The UI example and Text with scale factor is broken again 😓 but it's broken in Main as well so nothing to do with this PR.
nicopap
added
A-UI
mockersf
approved these changes
Sep 25, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
derive `Reflect` to `GlyphAtlasInfo`,`PositionedGlyph` and `TextLayoutInfo`. # Objective - I need reflection gets all components of the `TextBundle` and `clone_value` it ## Solution - registry it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
derive
ReflecttoGlyphAtlasInfo,PositionedGlyphandTextLayoutInfo.Objective
TextBundleandclone_valueitSolution