Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty morph weights when loading gltf #9867

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Handle empty morph weights when loading gltf #9867

merged 2 commits into from
Sep 20, 2023

Conversation

floppyhammer
Copy link
Contributor

@floppyhammer floppyhammer commented Sep 20, 2023 •
edited by alice-i-cecile
Loading

Objective

Fixes #9863.

Solution

Spawn MorphWeights after we handle MeshMorphWeights for the children.

@nicopap nicopap added C-Bug An unexpected or incorrect behavior A-Assets Load files from disk to use for things like images, models, and sounds A-Animation Make things move and change over time labels Sep 20, 2023
nicopap
nicopap approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 20, 2023
@james7132 james7132 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into bevyengine:main with commit 354a5b7 Sep 20, 2023
@floppyhammer floppyhammer deleted the vrm-support branch September 21, 2023 02:51
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@floppyhammer
Handle empty morph weights when loading gltf (bevyengine#9867)
31a2591 
# Objective

Fixes bevyengine#9863.

## Solution

Spawn `MorphWeights` after we handle `MeshMorphWeights` for the
children.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@nicopap nicopap nicopap approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There're scenarios in which morph targets is not zero but no weights in mesh
4 participants
@floppyhammer @james7132 @alice-i-cecile @nicopap