Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge _Reflect and _WithRegistry commands #9680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Merge _Reflect and _WithRegistry commands #9680

wants to merge 1 commit into from

Commits on Sep 26, 2023

  1. Merge InsertReflect and InsertReflectWithRegistry 

    While code was already effectively deduplicated, this further
deduplicates it, by removing InsertReflect and RemoveReflect, since they
were just specialized version of their _WithRegistry counterparts.

- Add ReadTypeRegistry trait, implemented for AsRef<TypeRegistry>
  and AppTypeRegistry
- Add default impl for ReflectCommandExt insert_reflect and
  remove_reflect methods
- Remove InsertReflect and RemoveReflect in favor of
  InsertReflectWithRegistry<AppTypeRegistry> and equivalent.
    @nicopap
    nicopap committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3baade9 View commit details
    Browse the repository at this point in the history