-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance many_cubes stress test use cases #9596
Conversation
8ad9615
to
e4bcc77
Compare
I see we use EDIT: Then I saw that bevymark seemed to want to use seeded StdRng and that's built into rand that is already a dependency so I switched to that instead. |
e4bcc77
to
e53a583
Compare
Swapping to |
047518b
to
81988f0
Compare
Switched to google's |
81988f0
to
fc0cbaf
Compare
fc0cbaf
to
4511968
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine and works as intended.
the logic for material selection is quite hard to follow. this is a stress test rather than a "guide" example so maybe not very important, but if i were going to be picky i would say it'd be clearer to initialize the materials upfront, then just use &materials[rng.range(0..materials.len())]
in the pbr bundles.
as written, i think if you use 2 textures it will generate a new material for every cube - upfront init would also avoid that.
Good call. It evolved as I was adding individual features but I like your suggestion. |
Default to the sphere layout as it is more useful for benchmarking. Add a benchmark mode that advances the camera by a fixed step to render the same frames across runs. Add an option to vary the material data per-instance. The color is randomized. Add an option to generate a number of textures and randomly choose one per instance. Use seeded StdRng for deterministic random numbers.
4511968
to
93fff17
Compare
# Objective - Make `many_cubes` suitable for testing various parts of the upcoming batching work. ## Solution - Use `argh` for CLI. - Default to the sphere layout as it is more useful for benchmarking. - Add a benchmark mode that advances the camera by a fixed step to render the same frames across runs. - Add an option to vary the material data per-instance. The color is randomized. - Add an option to generate a number of textures and randomly choose one per instance. - Use seeded `StdRng` for deterministic random numbers.
Objective
many_cubes
suitable for testing various parts of the upcoming batching work.Solution
argh
for CLI.StdRng
for deterministic random numbers.