Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch CI jobs between windows and linux for example execution #9489

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

mockersf
Copy link
Member

Objective

  • Example execution on linux/vulkan on CI is segfaulting for unclear reasons
  • This makes a lot of noise on PRs

Solution

  • Switch example execution on Linux to validation jobs (on PR merged). It will still crash but not block merging, and we'll know when it's fixed
  • Switch example execution on Windows to CI jobs (on PR push). It's a bit longer than on Linux but provides a useful status
  • Disable job commenting on PR with job execution to reduce noise

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Aug 18, 2023
@alice-i-cecile
Copy link
Member

I'm on board with the swap, but I'd prefer not to have commented out code. That's what version control is for! Don't block on this though.

@cart
Copy link
Member

cart commented Aug 18, 2023

This does seem to increase the run time of the job pretty significantly. The first run finished in 26 minutes, vs the 11-15 minutes on linux. If its 26 minutes every time, it will add an extra 10-ish minutes to every build (which used to take 15 ish minutes with the linux variant).

I trigger a second run for another datapoint.

@cart
Copy link
Member

cart commented Aug 18, 2023

Second run was 15 minutes. Nice!

Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also on board, but I agree that we should just remove the commented out section

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 19, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 19, 2023
Merged via the queue into bevyengine:main with commit 0087556 Aug 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants