Improve codegen for world validation #9464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-gio
added
A-ECS
|
Example |
mockersf
approved these changes
Aug 20, 2023
james7132
reviewed
Sep 21, 2023
Co-authored-by: James Liu <contact@jamessliu.com>
james7132
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
It does seem to work. There was a rough 300 fewer lines of assembly generated across several test cases for QueryState, a 14% decrease in codegen. Though the bulk of that seems to be in the symbols for panicking, this is still a decent win.
I'll kick off a merge once CI is fixed.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Improve code-gen for `QueryState::validate_world` and `SystemState::validate_world`. ## Solution * Move panics into separate, non-inlined functions, to reduce the code size of the outer methods. * Mark the panicking functions with `#[cold]` to help the compiler optimize for the happy path. * Mark the functions with `#[track_caller]` to make debugging easier. --------- Co-authored-by: James Liu <contact@jamessliu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Improve code-gen for
QueryState::validate_worldandSystemState::validate_world.Solution
#[cold]to help the compiler optimize for the happy path.#[track_caller]to make debugging easier.