Change UiScale to a tuple struct

[st0rmbtw]

Objective

Inconvenient initialization of UiScale

Solution

Change UiScale to a tuple struct

Migration Guide

Replace initialization of UiScale like UiScale { scale: 1.0 } with UiScale(1.0)

[github-actions]

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

[github-actions]

Example alien_cake_addict failed to run, please try running it locally and check the result.

[alice-i-cecile]

Nice and simple, but I'm not fully sold. Can you say a bit more about why you prefer this syntax?

[st0rmbtw]

It feels more consistent and looks nicer for me :)

[mockersf]

Would it be simpler to change the struct to a tuple struct? struct UiScale(f32);

[github-actions]

Example alien_cake_addict failed to run, please try running it locally and check the result.

[github-actions]

Example alien_cake_addict failed to run, please try running it locally and check the result.

[st0rmbtw]

I think so, but wouldn't it be a breaking change?

[alice-i-cecile]

Yep, but breaking changes are totally fine in Bevy at this stage. Especially for a very niche part of the API like this.

I'd prefer a tuple struct over the current change as well, although I'm neutral on tuple vs named struct.

[st0rmbtw]

Done

[mockersf]

I prefer named struct when the name brings new information. I don't think a single field scale on a UiScale struct brings much...

You can probably derive Deref and DerefMut for that struct, and you'll need to fix all the places it's used...

[st0rmbtw]

@mockersf Should I add a method like get to return a value of UiScale or just use .0 syntax?

[ickshonpe]

I prefer the tuple struct too.

[github-actions]

Example alien_cake_addict failed to run, please try running it locally and check the result.

[ickshonpe]

The UiScale doc comment isn't very informative atm. Maybe it could be changed to say something about how logical coordinates are multiplied by window scale factor and UiScale to get physical coordinates.

[tguichaoua]

IMHO tuple structs are better for wrapping a single meaningless value.
Also here it avoids the repetition of the word "scale".

[github-actions]

Example alien_cake_addict failed to run, please try running it locally and check the result.

[github-actions]

Example alien_cake_addict failed to run, please try running it locally and check the result.

[github-actions]

Example alien_cake_addict failed to run, please try running it locally and check the result.

[st0rmbtw]

@alice-i-cecile I think this PR is ready to merge