audio sinks don't need their custom drop anymore #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ooh, I was wondering if that would fix it |
alice-i-cecile
approved these changes
Aug 3, 2023
hymm
approved these changes
Aug 10, 2023
hymm
added
the
S-Ready-For-Final-Review
cart
pushed a commit
that referenced
this pull request
Aug 17, 2023
# Objective - Fixes #9324 - Audio sinks used to have a custom drop implementation to detach the sinks because it was not required to keep a reference to it - With the new audio api, a reference is kept as a component of an entity ## Solution - Remove that custom drop implementation, and the option wrapping that was required for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution