Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selection of iOS device in mobile example #9282

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

NiklasEi
Copy link
Member

Objective

  • Make sure that users can "just run" the mobile example
  • Device descriptions like iPhone SE (3rd generation) (F647334F-D7C1-4BD6-9B5F-0E3D9713C02B) (Shutdown) currently fail (issue found by @CleanCut)

Solution

  • Improve the script that grabs the device UUID from the device list

@NiklasEi NiklasEi added C-Examples An addition or correction to our examples O-iOS Specific to the iOS mobile operating system labels Jul 26, 2023
Copy link
Member

@CleanCut CleanCut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@NiklasEi NiklasEi force-pushed the improve_ios_device_selection branch from b9573e3 to 91fd34c Compare October 7, 2023 21:48
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 8, 2023
@mockersf mockersf added this pull request to the merge queue Oct 8, 2023
Merged via the queue into bevyengine:main with commit 46f3b26 Oct 8, 2023
22 checks passed
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
# Objective

- Make sure that users can "just run" the mobile example
- Device descriptions like `iPhone SE (3rd generation)
(F647334F-D7C1-4BD6-9B5F-0E3D9713C02B) (Shutdown)` currently fail
([issue
found](NiklasEi/bevy_game_template#61 (comment))
by @CleanCut)

## Solution

- Improve the script that grabs the device UUID from the device list
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
# Objective

- Make sure that users can "just run" the mobile example
- Device descriptions like `iPhone SE (3rd generation)
(F647334F-D7C1-4BD6-9B5F-0E3D9713C02B) (Shutdown)` currently fail
([issue
found](NiklasEi/bevy_game_template#61 (comment))
by @CleanCut)

## Solution

- Improve the script that grabs the device UUID from the device list
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
# Objective

- Make sure that users can "just run" the mobile example
- Device descriptions like `iPhone SE (3rd generation)
(F647334F-D7C1-4BD6-9B5F-0E3D9713C02B) (Shutdown)` currently fail
([issue
found](NiklasEi/bevy_game_template#61 (comment))
by @CleanCut)

## Solution

- Improve the script that grabs the device UUID from the device list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Examples An addition or correction to our examples O-iOS Specific to the iOS mobile operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants