Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark valid scenes with component #9117

Closed
wants to merge 2 commits into from
Closed

Mark valid scenes with component #9117

wants to merge 2 commits into from

Conversation

Olle-Lukowski
Copy link
Contributor

Objective

Fixes #9115

Solution

Added a ValidScene Component, as the issue suggests.

@Shatur
Copy link
Contributor

Shatur commented Jul 11, 2023

You need to insert it to scene entity. And remove when scene becomes despawned / re-loaded.

@mockersf mockersf added A-Scenes Serialized ECS data stored on the disk X-Controversial There is active debate or serious implications around merging this PR labels Jul 11, 2023
@mockersf
Copy link
Member

marking as controversial until the discussion in the issue is resolved

alice-i-cecile
alice-i-cecile reviewed Jul 12, 2023
View reviewed changes
crates/bevy_scene/src/scene_spawner.rs
@@ -28,6 +29,9 @@ impl InstanceId {
}
}

#[derive(Component)]
pub struct ValidScene;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs doc strings.

@Shatur Shatur mentioned this pull request Jul 31, 2023
Merged
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Aug 14, 2023 •
edited
Loading

Closed in favor of #9115. Thanks for proposing and discussing this: it really helped us find a better solution.

github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2023
@Shatur
Add SceneInstanceReady (#9313)
d60b715 
# Objective

Closes #9115, replaces #9117.

## Solution

Emit event when scene is ready.

---

## Changelog

### Added

- `SceneInstanceReady` event when scene becomes ready.
Shatur added a commit to projectharmonia/bevy that referenced this pull request Aug 19, 2023
@Shatur
Add SceneInstanceReady (bevyengine#9313)
b9e6d15 
# Objective

Closes bevyengine#9115, replaces bevyengine#9117.

## Solution

Emit event when scene is ready.

---

## Changelog

### Added

- `SceneInstanceReady` event when scene becomes ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit event when scene is ready
4 participants
@Olle-Lukowski @Shatur @mockersf @alice-i-cecile