-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in NamedTypePathDef #9102
Fix typo in NamedTypePathDef #9102
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
@Cptn-Sherman Despite this being merged, can you still provide a Migration Guide by editing your first message? Even though this is trivial, it is a breaking change and will need to appear in the migration guide of 0.11->0.12 which will be pulled automatically from this PR. |
I have updated my original message. Please let me know if this guide is insufficient, I did not see any documentation in the contributing guide on adding a migration guide. |
Thank you! It's in the placeholder when you create the PR I think. But it should be added to the contributing guide yeah :( Maybe add a sentence before "Renamed Edit: here: #9104 |
Objective
Fixes #9091
Solution
Rename instances of
Primtive
toPrimitive
Migration Guide
Before:
After: