Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix morph target prepass shader #9013

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Fix morph target prepass shader #9013

merged 1 commit into from
Jul 2, 2023

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Jul 1, 2023

Objective

Since 10f5c92, shadows were broken for models with morph target.

When #5703 was merged, the morph target code in render/mesh.wgsl was correctly updated to use the new import syntax. However, similar code exists in prepass/prepass.wgsl, but it was never update. (the reason code is duplicated is that the Vertex struct is different for both files).

Solution

Update the code, so that shadows render correctly with morph targets.

@nicopap nicopap added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! A-Animation Make things move and change over time labels Jul 1, 2023
@nicopap nicopap added this to the 0.11 milestone Jul 1, 2023
superdump
superdump approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@superdump superdump added this pull request to the merge queue Jul 2, 2023
Merged via the queue into bevyengine:main with commit 889a5fb Jul 2, 2023
@nicopap nicopap deleted the fix-morph-prepass branch August 30, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@nicopap @superdump @mockersf