Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API updates to the AnimationPlayer #9002

Merged
merged 31 commits into from
Aug 28, 2023
Merged

API updates to the AnimationPlayer #9002

merged 31 commits into from
Aug 28, 2023

Commits on Jun 30, 2023

  1. RepeatAnimation, is_playback_reversed(), is_finished(), animation upd… 

    …ates
    @DevinLeamy
    DevinLeamy committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    e663e51 View commit details
    Browse the repository at this point in the history

  2. Apply modulo to elapsed time

    @DevinLeamy
    DevinLeamy committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    a6488df View commit details
    Browse the repository at this point in the history

  3. Greater than or equals

    @DevinLeamy
    DevinLeamy committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    169a94c View commit details
    Browse the repository at this point in the history

  4. lint

    @DevinLeamy
    DevinLeamy committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    1400461 View commit details
    Browse the repository at this point in the history

  5. Updated names and comments

    @DevinLeamy
    DevinLeamy committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    6e3b15c View commit details
    Browse the repository at this point in the history

  6. Typo

    @DevinLeamy
    DevinLeamy committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    eec1240 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Added animation_clip() accessor and made animation_clip optional

    @DevinLeamy
    DevinLeamy committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    a9f82a3 View commit details
    Browse the repository at this point in the history

  2. lint

    @DevinLeamy
    DevinLeamy committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    a920e90 View commit details
    Browse the repository at this point in the history

  3. Updated comment

    @DevinLeamy
    DevinLeamy committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    57df0ac View commit details
    Browse the repository at this point in the history

  4. Conditionally update the elapsed time

    @DevinLeamy
    DevinLeamy committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    5af3277 View commit details
    Browse the repository at this point in the history

  5. repeat_mode() and completions() public accessors

    @DevinLeamy
    DevinLeamy committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    1d829db View commit details
    Browse the repository at this point in the history

  6. Updated comment

    @DevinLeamy
    DevinLeamy committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    3ad8d27 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Implement default for RepeatAnimation, with Never as the default

    @DevinLeamy
    DevinLeamy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    62c67e5 View commit details
    Browse the repository at this point in the history

  2. Renamed PlayingAnimation::finished to PlayingAnimation::is_finished t… 

    …o match the AnimationPlayer
    @DevinLeamy
    DevinLeamy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d36d5bc View commit details
    Browse the repository at this point in the history

  3. animation_clip: Handle<AnimationClip>, rather than Option<Handle<Anim… 

    …ationClip>>
    @DevinLeamy
    DevinLeamy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a3a7eb4 View commit details
    Browse the repository at this point in the history

  4. Introduced seek_time and PlayingAnimation::update()

    @DevinLeamy
    DevinLeamy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    60fc68c View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Introduced AnimationPlayer::replay() to reset the PlayingAnimation's … 

    …to its initial state
    @DevinLeamy
    DevinLeamy committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    63a71b6 View commit details
    Browse the repository at this point in the history

  2. Removed AnimationPlayer::stop_repeating() and added a comment to Anim… 

    …ationPlayer::repeat()
    @DevinLeamy
    DevinLeamy committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    88fd036 View commit details
    Browse the repository at this point in the history

  3. Updated examples

    @DevinLeamy
    DevinLeamy committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    764ae7e View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @DevinLeamy
    DevinLeamy committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e028c17 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/bevyengine/bevy into animat… 

    …ion-api
    @DevinLeamy
    DevinLeamy committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f09ce88 View commit details
    Browse the repository at this point in the history

  6. nit: fix comment

    @DevinLeamy
    DevinLeamy committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9670723 View commit details
    Browse the repository at this point in the history

  7. Nit: improved comment 

    Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
    @DevinLeamy @Shatur
    DevinLeamy and Shatur committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    1d2a9b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Replaced deprecated for_each_mut with for_each

    @DevinLeamy
    DevinLeamy committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    d59789b View commit details
    Browse the repository at this point in the history

  2. Updated animated_fox example to showcase the repeat modes

    @DevinLeamy
    DevinLeamy committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    011d13f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'animation-api' of https://github.com/DevinLeamy/bevy in… 

    …to animation-api
    @DevinLeamy
    DevinLeamy committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5b8da3f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/bevyengine/bevy into animat… 

    …ion-api
    @DevinLeamy
    DevinLeamy committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f52c991 View commit details
    Browse the repository at this point in the history

  5. nit: format

    @DevinLeamy
    DevinLeamy committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    7910f05 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Reformat comments + re-run CI, post moving run-examples over to windows

    @DevinLeamy
    DevinLeamy committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6527d72 View commit details
    Browse the repository at this point in the history

  2. nit: cargo fmt --all

    @DevinLeamy
    DevinLeamy committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f50c8c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Applied suggestions (updates to comments and inlines) 

    Co-authored-by: François <mockersf@gmail.com>
    @DevinLeamy @mockersf
    DevinLeamy and mockersf committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    8d3b642 View commit details
    Browse the repository at this point in the history