Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl From<String> and From<&str> for TextSection #8856

Merged
merged 10 commits into from
Sep 11, 2023
Merged

impl From<String> and From<&str> for TextSection #8856

merged 10 commits into from
Sep 11, 2023

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jun 16, 2023 •
edited
Loading

Objective

Implement From<String> and From<&str> for TextSection

Example from something I was working on earlier:

parent.spawn(TextBundle::from_sections([
    TextSection::new("press ".to_string(), TextStyle::default()),
    TextSection::new("space".to_string(), TextStyle { color: Color::YELLOW, ..default() }),
    TextSection::new(" to advance frames".to_string(), TextStyle::default()),
]));

After an impl From<&str> for TextSection :

parent.spawn(TextBundle::from_sections([
    "press ".into(),
    TextSection::new("space".to_string(), TextStyle { color: Color::YELLOW, ..default() }),
    " to advance frames".into(),
]));
  • Potentially unhelpful without a default font, so behind the default_font feature.

Co-authored-by: hate

@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jun 16, 2023
@simdimdim
Copy link

It'd be nice if this makes it into 0.11

@mockersf
Copy link
Member

could you use it in some examples, and explaining how it uses the default font and depend on the feature?

hate and others added 7 commits August 17, 2023 21:29
@hate
Add an example using the default_font feature
07e410f
@ickshonpe
Merge branch 'bevyengine:main' into textsection-from
51ce1ac
@ickshonpe
Removed DefaultFont marker component from example.
6b77605
@ickshonpe
Merge branch 'textsection-from' of https://github.com/ickshonpe/bevy …
7e9eb4f 
…into textsection-from
@ickshonpe
cargo fmt
3d511b0
@ickshonpe
Adds:
26e191e 
```
impl <I> From<I> for TextBundle where I: Into<TextSection> {
    fn from(value: I) -> Self {
        Self::from_sections(vec![value.into()])
    }
}
```

Which allows ```TextBundle::from("some text")``` when default fonts are enabled.
@ickshonpe
cargo fmt
ab3c539
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 6, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 11, 2023
Merged via the queue into bevyengine:main with commit 625d386 Sep 11, 2023
21 checks passed
@cart cart mentioned this pull request Oct 13, 2023
Merged
43 tasks
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@ickshonpe @hate
impl From<String> and From<&str> for TextSection (bevyengine#8856)
66f95d7 
# Objective

Implement `From<String>` and `From<&str>` for `TextSection`

Example from something I was working on earlier:
```rust
parent.spawn(TextBundle::from_sections([
    TextSection::new("press ".to_string(), TextStyle::default()),
    TextSection::new("space".to_string(), TextStyle { color: Color::YELLOW, ..default() }),
    TextSection::new(" to advance frames".to_string(), TextStyle::default()),
]));
```

After an `impl From<&str> for TextSection` :

```rust
parent.spawn(TextBundle::from_sections([
    "press ".into(),
    TextSection::new("space".to_string(), TextStyle { color: Color::YELLOW, ..default() }),
    " to advance frames".into(),
]));
```

* Potentially unhelpful without a default font, so behind the
`default_font` feature.

 Co-authored-by: [hate](https://github.com/hate)

---------

Co-authored-by: hate <15314665+hate@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm hymm approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ickshonpe @simdimdim @mockersf @hymm @alice-i-cecile @hate